Re: [PATCHv3 0/3] git-gui: more robust handling of fancy repos
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Dec 6, 2009, 13:43 UTC
- Message-ID
- <cb7bb73a0912060543x6e7b2d28xfcd9bef4db3af1b8@mail.gmail.com>
- In-Reply-To
- <36ca99e90912060459u1073288bj2114f8ab56c7224b@mail.gmail.com>
On Sun, Dec 6, 2009 at 1:59 PM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
Show 11 quoted lines
> Here it is:
>
> [guitool "exclude/Ignore file"]
> cmd = echo \"$FILENAME\" >> \"${GIT_DIR:=.git}/info/exclude\"
> noconsole = yes
> needsfile = yes
>
> The purpose is simple: add the current file to the info/exclude file
> in the git dir As you can see, I have a workaround for not having
> GIT_DIR in the env, which should solve the issue. But it would be nice
> to rely on this.Yup. I'm thinking about setting both $GIT_DIR and $GIT_WORK_TREE once and for all at the end of the repo setup. This should also spare us setting it up specifically for gitk (and then separately for the tools). The question is: should it be done the way it's done for gitk (i.e. normalizing the paths), or just use it as-is? In the latter case, the question would be why is the path being normalized before gitk is invoked.
Ideas?
-- Giuseppe "Oblomov" Bilotta