Re: [PATCH/RESEND] gitweb: Fix snapshots requested via PATH_INFO

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Apr 15, 2009, 11:29 UTC
Message-ID: <cb7bb73a0904150429l7c9910aer847464add60ee345@mail.gmail.com>
In-Reply-To: <20090415100955.GA33221014@CIS.FU-Berlin.DE>

2009/4/15 Holger Weiß <holger@zedat.fu-berlin.de>:

> * Giuseppe Bilotta <giuseppe.bilotta@gmail.com> [2009-04-15 11:33]:

Show 11 quoted lines

>> My gitweb over at http://git.oblomov.eu/ supports snapshots with
>> PATH_INFO just fine even without the need for this patch.
>
> Really?  If I try to download a snapshot from your site, I get an empty
> tarball (and the server appends an additional ".tar.gz" suffix to the
> filename within the "Content-disposition" header).  For example:
>
> $ wget -q -O - http://git.oblomov.eu/git/snapshot/v1.6.2.3.tar.gz | gzip -d | tar -t | wc -l
> 0
>
> That's the bug which is fixed by my patch.

This gets weirder and weirder. I'm seeing the same behaviour with your patch. I think I busted something the upgrade I was running this morning. Even git archive on the command line gives me an empty tar.

I have no idea what happened. I rebuilt and reinstalled git and now it's working again, and I see the problem too, and yes your patch fixes it.

-- 
Giuseppe "Oblomov" Bilotta