Re: [tig PATCH] Predefined external command: git commit

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Feb 21, 2009, 17:19 UTC
Message-ID: <cb7bb73a0902210919n45ffb74fp6d4fa0dc9cb7ac1@mail.gmail.com>
In-Reply-To: <2c6b72b30902210819q43cbf184x77d7587a6aa1630a@mail.gmail.com>

On Sat, Feb 21, 2009 at 5:19 PM, Jonas Fonseca <jonas.fonseca@gmail.com> wrote:

Show 7 quoted lines

> On Sat, Feb 21, 2009 at 01:28, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>> It might make sense to map 'A' to 'git commit --amend', too, even though
>> that key is currently taken by author display toggle.
>
> We could remap author toggling to 'a' to free 'A'. I assume you want
> 'A' to make it less likely to be pressed by accident?

Actually it was more for consistency (uppercase C, uppercase A), but it could be considered for that purpose: it makes sense to have actions that change the repo harder to hit by accident.

> BTW, to make the keybinding more scalable, the option toggling should
> probably be hidden behind a common prefix key, which would open a menu
> with next key searching this menu.

Since t is taken by tree view, we could have 'o' for options. However, it IS a nice thing to have quick toggles for the most common ones.

> Thanks for both patches.

Thank you for this excellent piece of software. I have some more minor patches up at git://git.oblomov.eu/tig (gitweb at same address with http) which I'm going to submit soon.

I honestly wish I could contribute with some more important feature such as bundle support or automatic color inversion on light backgrounds.

-- 
Giuseppe "Oblomov" Bilotta