Re: [PATCH] gitweb: support the rel=vcs microformat

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Jan 7, 2009, 18:03 UTC
Message-ID: <cb7bb73a0901071003m77482a99wf6f3988beb5b5e78@mail.gmail.com>
In-Reply-To: <20090107155023.GA16540@gnu.kitenet.net>

On Wed, Jan 7, 2009 at 4:50 PM, Joey Hess <joey@kitenet.net> wrote:

Show 12 quoted lines

> Giuseppe Bilotta wrote:
>> In this patch you do NOT add titles to the rel=vcs links, which means that
>> everything works fine only if there is a single URL for each project. If a
>> project has different URLs, it's going to appear multiple times as _different_
>> projects to a spec-compliant reader.
>>
>> A possible solution would be to make @git_url_list into a map keyed by the
>> project name and having the description and repo URL(s) as values.
>
> Yes. I considered doing that, but didn't immediatly see a way to get the
> project description w/o additional overhead (of looking it up a second
> time).

The solution I have in mind would be something like this: in summary or projects list view (which are the views in which we put the links, and also the views in which we loop up the repo URL and the description anyway), you fill up former @git_url_list (now %project_metadata) looking up the repo description and URLs. You then use this information both in the link tag and in the appropriate places for the visible part of the webpage: you don't have a significant overhead, because you're just moving the project description retrieval early on.

You probably want to refactor the code by making a git_get_project_metadata() sub that extends the current URL retrieval by retrieving description and URLs. The routine can then be used either for one or for all the projects, as needed.

> Thanks for the feedback. There are some changes happening to the
> microformat that should make gitweb's job slightly easier, I'll respin
> the patch soon.

Let me know about this too, I very much like the idea of this microformat.

-- 
Giuseppe "Oblomov" Bilotta