git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFCv4 3/3] gitweb: link to patch(es) view from commit and log views

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Dec 16, 2008, 11:14 UTC
Message-ID
<cb7bb73a0812160314t4a74dbb3r4748ad9190a88bd6@mail.gmail.com>
In-Reply-To
<200812161114.35336.jnareb@gmail.com>
On Tue, Dec 16, 2008 at 11:14 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> You lost CC, somehow...
Duh, clicked the wrong button.
Show 17 quoted lines
>>> I wonder if it would make sense to pass
>>>
>>>   href(..., hash_parent => $commitlist[-1]{'id'}, ...)
>>>
>>> here. But I think having separate "patches" action, with intent being
>>> displaying series of patches, is a better solution. This way you can
>>> see in URL and in the page title (thus also in window title, or in
>>> bookmark name) if it is single patch or patch series (perhaps consisting
>>> of single patch).
>>
>> I'm not sure I'm following you here. Do you mean as in manually adding
>> the parent endpoint to the URL when it's not specified in the log view
>> itself? I think that would change the behaviour for > 100 patches.
>
> First, I meant here that having separate "patches" action is a good
> idea in itself, whether we pass explicitly and always $hash_parent
> parameter here or not.

I'm not too sure about that. Do we pass the actual hash parent, or just the last patch that would be included due to the patch limit? This, btw, is an issue that should resolved with patch view: it should warn when the patch limit is reached before all intended patches are output. I'm just not sure about how to do it.

Show 8 quoted lines
> Second, I haven't thought about interaction with (short)log
> pagination; in $patch_max < 0, i.e. unlimited patches, and most
> common case of running 'shortlog' action without 'hp' (hash_parent)
> limiter used, one would make 'patches' limited to page size,
> other unlimited.  On one hand side limiting to page size makes
> "patches" be more of equivalent of current "shortlog" view; on the
> other hand it makes 'unlimited' actually be limited to page size,
> at least in this situation...

Consider that switching from log to shortlog view doesn't respect pagination (e.g. if you're on page 3 of shortlog and click on log you go to page 1 of log) I would be inclined to keep patches behaviour independent of log view pagination.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Jakub NarebskiNext: Jakub Narebski
Message 11 of 12 in “[RFCv4 0/3] gitweb: patch view”
  1. Giuseppe BilottaDec 6, 2008
  2. 1/3 gitweb: add patch viewGiuseppe Bilotta, Dec 6, 2008
  3. 2/3 gitweb: add patches viewGiuseppe Bilotta, Dec 6, 2008
  4. 3/3 gitweb: link to patch(es) view from commit and log viewsGiuseppe Bilotta, Dec 6, 2008
  5. Jakub NarebskiDec 16, 2008
  6. Jakub NarebskiDec 16, 2008
  7. Jakub NarebskiDec 15, 2008
  8. Giuseppe BilottaDec 15, 2008
  9. Jakub NarebskiDec 15, 2008
  10. Jakub NarebskiDec 16, 2008
  11. Giuseppe BilottaDec 16, 2008
  12. Jakub NarebskiDec 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.