Re: [PATCH] format-patch: autonumber by default

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Oct 2, 2008, 13:10 UTC
Message-ID: <cb7bb73a0810020610q657dec7clf85b4ef3575b751f@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.0810021433130.22125@pacific.mpi-cbg.de.mpi-cbg.de>

On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 12 quoted lines

> Hi,
>
> On Thu, 2 Oct 2008, Giuseppe Bilotta wrote:
>
>> Set auto-number true by default, allowing the format.number key to be
>> set to 'noauto' to override this.
>> ---
>>  builtin-log.c |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> Interesting.  No sign-off, no defense why this is actually desirable,
> after we lived for so long without this behavior... Care to elaborate?

Doh, sorry about the Sign-off, I'll resend with.

Now, about the reason for this patch: I would say that the most common use-case of format-patch being used to prepare multiple patches is when one plans on sending a patchset. When format.numbering is set to auto, single-patches will still be extracted without numbers, but patchset will be properly numbered.

Of course, there may be cases where one doesn't want numbering (for which there is the -N flag already), and of course we want to give the user the choice to disable autonumbering at the config level, for which there is the new noauto option for format.numbering.

If this explanation is good enough for you, I'll plop it in the resend message too :)

-- 
Giuseppe "Oblomov" Bilotta