Re: What's cooking in gitweb (20 Sep 2008)

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Sep 21, 2008, 20:22 UTC
Message-ID: <cb7bb73a0809211322q5aa6d8ex88651aa33a6c2688@mail.gmail.com>
In-Reply-To: <200809210138.01874.jnareb@gmail.com>

Hi Jakub, hi all,

sorry for the late reply, I was out of town and connectionless for two weeks and I'm getting back on track now.

Show 16 quoted lines

> 1. "gitweb pathinfo improvements" by Giuseppe Bilotta
>   Message-ID: <1220435839-29360-1-git-send-email-giuseppe.bilotta@gmail.com>
>   http://$gmane/94779
>
>   Table of contents:
>   ==================
>    * [PATCH 1/5] gitweb: action in path with use_pathinfo
>    * [PATCH 2/5] gitweb: use_pathinfo filenames start with /
>    * [PATCH 3/5] gitweb: parse parent..current syntax from pathinfo
>    * [PATCH 4/5] gitweb: use_pathinfo creates parent..current paths
>    * [PATCH 5/5] gitweb: remove PATH_INFO from $my_url and $my_uri
>
>   Need some refinement, especially with respect to _generating_
>   path_info URLs inside gitweb.  Some patches (2 and 5) does not
>   need correction, and probably should be sent as separate series.
>   Author promised to resend series, if I remember correctly.

I'll resend the whole series (plus an additional patch to fix an aesthetical issue I found recently) as soon as I fix the url generation for the dotted filename corner case (which by re-reading the past emails seemed to be the only significant issue, correct?). Should be shortly

Show 15 quoted lines

> 2. "[PATCH] gitweb: shortlog now also obeys $hash_parent" by Giuseppe Bilotta
>   Message-ID: <1218204731-9931-1-git-send-email-giuseppe.bilotta@gmail.com>
>   http://$gmane/91666
>
>   Very good idea, but for the following two caveats.  The name
>   '$commit_hash' is a bit strange to mean also revision range; passing
>   "a..b" to parse_commits()... well, it is a good solution, but for me it
>   feels a bit hacky.  But this is not something serious.
>
>   More importnat fact is that I'd very much like for _all_ log-like views
>   (perhaps with exception of feeds: Atom and RSS) to implement this
>   feature.  This could be done by either doing it all in the same commit,
>   doing commit series changing 'shortlog', 'log' and 'history' separately,
>   or what I would prefer actually, to refactor generation of log-like views
>   to use single worker/engine subroutine.

I agree that refactoring is probably the best idea. It will also take me some more time ;)

BTW, I haven't heard from Lea, so can I just assume that my patches don't touch any of her caching improvements?

-- 
Giuseppe "Oblomov" Bilotta