git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] hg-to-git: abort if the project directory is not a hg repo

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Jul 6, 2008, 03:15 UTC
Message-ID
<ca2e01fa1446afa551f5a6a36242a03d79cb685c.1215313871.git.vmiklos@frugalware.org>
In-Reply-To
<89a68bb21125c4ff706412cde5c04f5d96658789.1215313871.git.vmiklos@frugalware.org>

Check the exit code of the first hg command, and abort to avoid a later ValueError exception.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 contrib/hg-to-git/hg-to-git.py |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py
index 25d9941..130b1c4 100755
--- a/contrib/hg-to-git/hg-to-git.py
+++ b/contrib/hg-to-git/hg-to-git.py
@@ -106,7 +106,10 @@ if state:
     else:
         print 'State does not exist, first run'
 
-tip = os.popen('hg tip --template "{rev}"').read()
+sock = os.popen('hg tip --template "{rev}"')
+tip = sock.read()
+if sock.close():
+    sys.exit(1)
 if verbose:
     print 'tip is', tip
 
-- 
1.5.6.1.322.ge904b.dirty
Previous: Miklos VajnaNext: Miklos Vajna
Message 3 of 6 in “hg-to-git fixes”
  1. 0/5 hg-to-git fixesMiklos Vajna, Jul 6, 2008
  2. 1/5 hg-to-git: avoid raising a string exceptionMiklos Vajna, Jul 6, 2008
  3. 2/5 hg-to-git: abort if the project directory is not a hg repoMiklos Vajna, Jul 6, 2008
  4. 3/5 hg-to-git: rewrite "git-frotz" to "git frotz"Miklos Vajna, Jul 6, 2008
  5. 4/5 hg-to-git: use git init instead of git init-dbMiklos Vajna, Jul 6, 2008
  6. 5/5 hg-to-git: use git rev-parse instead of git showMiklos Vajna, Jul 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.