Re: [PATCH] bundle: do not free uninitialized memory on bad arguments
- From
- Olof Fairbrook <olof.fairbrook@gmail.com>
- Date
- Oct 19, 2026, 10:25 UTC
- Message-ID
- <c9d2099e-4eab-6be2-10a3-c30f33c88b8b@gmail.com>
- In-Reply-To
- <atW95CyeiQCGtIMX@pks.im>
On Mon, 19 Oct 2026, Patrick Steinhardt wrote:
Show 5 quoted lines
>> in object_array_clear() and in free(); whether the command crashes >> depends on what happens to be on the stack. > > Nit: that last sentence is a bit on the verbose side, as it doesn't > really give any more useful information. I'd just drop it.
Yes, agreed. Just me over explaining. Will keep that in mind for future messages on the list.
Show 9 quoted lines
>> test_commit -C foo x && > > I think overall this looks good enough already, and the nits I have > raised do not really need to be addressed. > > Thanks! > > Patrick >
Thank you! Olof