git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bundle: do not free uninitialized memory on bad arguments

From
OFOlof Fairbrook <olof.fairbrook@gmail.com>
Date
Oct 19, 2026, 10:25 UTC
Message-ID
<c9d2099e-4eab-6be2-10a3-c30f33c88b8b@gmail.com>
In-Reply-To
<atW95CyeiQCGtIMX@pks.im>
On Mon, 19 Oct 2026, Patrick Steinhardt wrote:
Show 5 quoted lines
>> in object_array_clear() and in free(); whether the command crashes
>> depends on what happens to be on the stack.
>
> Nit: that last sentence is a bit on the verbose side, as it doesn't
> really give any more useful information. I'd just drop it.

Yes, agreed. Just me over explaining. Will keep that in mind for future messages on the list.

Show 9 quoted lines
>>  	test_commit -C foo x &&
>
> I think overall this looks good enough already, and the nits I have
> raised do not really need to be addressed.
>
> Thanks!
>
> Patrick
>

Thank you! Olof

Previous: Patrick SteinhardtNext: Harald Nordgren
Message 3 of 6 in “bundle: do not free uninitialized memory on bad arguments”
  1. bundle: do not free uninitialized memory on bad argumentsOlof Fairbrook, Oct 18, 2026
  2. Patrick SteinhardtOct 19, 2026
  3. Olof FairbrookOct 19, 2026
  4. Harald NordgrenOct 19, 2026
  5. Olof FairbrookOct 19, 2026
  6. Junio C HamanoOct 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.