Re: [Outreachy][PATCH 0/1] builtin/branch.c: ammend die() error message

From: Dragan Simic <dsimic@manjaro.org>
Date: Oct 11, 2023, 15:34 UTC
Message-ID: <c98dd0b5988f9889ee4c2b5d4e645839@manjaro.org>
In-Reply-To: <20231011152424.6957-1-isokenjune@gmail.com>

On 2023-10-11 17:24, Isoken June Ibizugbe wrote:

Show 10 quoted lines

> This patch improves the consistency and clarity of error messages
> across Git commands. It adheres to Git's Coding Guidelines for error
> messages:
> 
> - Error messages no longer end with a full stop.
> - Capitalization is avoided in error messages.
> - Error messages lead with a description of the issue, enhancing 
> readability.
> 
> Signed-off-by: Isoken June Ibizugbe <isokenjune@gmail.com>

When there's only one patch and not a series, there's no need for a cover letter, and the description of the patch actually needs to go into the patch itself, so it can be latter pulled into the repository as part of the patch submission.

Show 5 quoted lines

> Isoken June Ibizugbe (1):
>   branch.c: ammend error messages for die()
> 
>  builtin/branch.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)