Re: PATCH 1/2] -Wuninitialized: remove some 'init-self' workarounds

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mar 20, 2018, 01:33 UTC
Message-ID: <c9748dfd-4293-140f-e753-8736bc196ab0@ramsayjones.plus.com>
In-Reply-To: <946e0ff9-307c-6886-6ade-7bd37cc9f97f@ramsayjones.plus.com>

On 19/03/18 17:54, Ramsay Jones wrote:

Show 7 quoted lines

> 
> The 'self-initialised' variables construct (ie <type> var = var;) has
> been used to silence gcc '-W[maybe-]uninitialized' warnings. This has,
> unfortunately, caused MSVC to issue 'uninitialized variable' warnings.
> Also, using clang static analysis causes complaints about an 'Assigned
> value is garbage or undefined'.
>

[snip]

Hi Junio,

You may not have noticed that I messed up the Subject line of this patch - I managed to drop the '[' character in the patch prefix string. :(

So, the commit 7bc195d877 on the 'pu' branch is titled:

  "PATCH 1/2] -Wininitialized: remove some 'init-self' workarounds"

Ahem! Sorry about that.

ATB, Ramsay Jones