Re: [PATCH 3/6] config.c: add repo_config_set_worktree_gently()

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 30, 2019, 16:40 UTC
Message-ID: <c8ff5919-5a27-8d1f-8583-241e94f0e196@gmail.com>
In-Reply-To: <20181227155611.10585-4-pclouds@gmail.com>

On 12/27/2018 10:56 AM, Nguyễn Thái Ngọc Duy wrote:

Show 14 quoted lines

> diff --git a/config.h b/config.h
> index ee5d3fa7b4..62204dc252 100644
> --- a/config.h
> +++ b/config.h
> @@ -103,6 +103,9 @@ extern int git_config_color(char *, const char *, const char *);
>  extern int git_config_set_in_file_gently(const char *, const char *, const char *);
>  extern void git_config_set_in_file(const char *, const char *, const char *);
>  extern int git_config_set_gently(const char *, const char *);
> +extern int repo_config_set_gently(struct repository *, const char *, const char *);
> +extern void repo_config_set(struct repository *, const char *, const char *);
> +extern int repo_config_set_worktree_gently(struct repository *, const char *, const char *);
>  extern void git_config_set(const char *, const char *);
>  extern int git_config_parse_key(const char *, char **, int *);
>  extern int git_config_key_is_valid(const char *key);

I know this is an old thread, but the patch is still in 'pu'. These methods do not appear to have any callers. Perhaps this patch should be dropped until there is a reason to include it?

Thanks, -Stolee