git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 23/23] remote: use exact HEAD lookup if it is available

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 24, 2009, 09:51 UTC
Message-ID
<c87a95887e5de0258fa4d32f3aac195768b39949.1235467368.git.jaysoffian@gmail.com>
In-Reply-To
<cover.1235467368.git.jaysoffian@gmail.com>
From: Jeff King <peff@peff.net>

Our usual method for determining the ref pointed to by HEAD is to compare HEAD's sha1 to the sha1 of all refs, trying to find a unique match.

However, some transports actually get to look at HEAD directly; we should make use of that information when it is available. Currently, only http remotes support this feature.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
 remote.c              |   10 ++++++++++
 t/t5550-http-fetch.sh |   11 +++++++++++
 2 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/remote.c b/remote.c
index 96d5c95..682af74 100644
--- a/remote.c
+++ b/remote.c
@@ -1449,6 +1449,16 @@ struct ref *guess_remote_head(const struct ref *head,
 	if (!head)
 		return NULL;
 
+	/*
+	 * Some transports support directly peeking at
+	 * where HEAD points; if that is the case, then
+	 * we don't have to guess.
+	 */
+	if (head->symref) {
+		r = find_ref_by_name(refs, head->symref);
+		return r ? copy_ref_with_peer(r) : NULL;
+	}
+
 	/* If refs/heads/master could be right, it is. */
 	if (!all) {
 		const struct ref *m;
diff --git a/t/t5550-http-fetch.sh b/t/t5550-http-fetch.sh
index b6e6ec9..05b1b62 100755
--- a/t/t5550-http-fetch.sh
+++ b/t/t5550-http-fetch.sh
@@ -42,5 +42,16 @@ test_expect_success 'fetch changes via http' '
 	test_cmp file clone/file
 '
 
+test_expect_success 'http remote detects correct HEAD' '
+	git push public master:other &&
+	(cd clone &&
+	 git remote set-head origin -d &&
+	 git remote set-head origin -a &&
+	 git symbolic-ref refs/remotes/origin/HEAD > output &&
+	 echo refs/remotes/origin/master > expect &&
+	 test_cmp expect output
+	)
+'
+
 stop_httpd
 test_done
-- 
1.6.2.rc1.291.g83eb
Previous: Jay Soffian
Message 23 of 23 in “builtin-clone: move locate_head() to remote.c so it can be re-used”
  1. 01/23 builtin-clone: move locate_head() to remote.c so it can be re-usedJay Soffian, Feb 24, 2009
  2. 02/23 builtin-remote: move duplicated cleanup code its own functionJay Soffian, Feb 24, 2009
  3. 03/23 builtin-remote: teach show to display remote HEADJay Soffian, Feb 24, 2009
  4. 04/23 builtin-remote: add set-head subcommandJay Soffian, Feb 24, 2009
  5. 05/23 builtin-remote: better handling of multiple remote HEADsJay Soffian, Feb 24, 2009
  6. 06/23 remote.c: make match_refs() copy src ref before assigning to peer_refJay Soffian, Feb 24, 2009
  7. 07/23 remote.c: don't short-circuit match_refs() when error in match_explicit_refs()Jay Soffian, Feb 24, 2009
  8. 08/23 refactor duplicated get_local_heads() to remote.cJay Soffian, Feb 24, 2009
  9. 09/23 refactor duplicated ref_newer() to remote.cJay Soffian, Feb 24, 2009
  10. 10/23 string-list: new for_each_string_list() functionJay Soffian, Feb 24, 2009
  11. 11/23 builtin-remote: rename variable and eliminate redundant function callJay Soffian, Feb 24, 2009
  12. 12/23 builtin-remote: name remote_refs consistentlyJay Soffian, Feb 24, 2009
  13. 13/23 builtin-remote: remove unused code in get_ref_statesJay Soffian, Feb 24, 2009
  14. 14/23 builtin-remote: fix two inconsistencies in the output of "show <remote>"Jay Soffian, Feb 24, 2009
  15. 15/23 builtin-remote: make get_remote_ref_states() always populate states.trackedJay Soffian, Feb 24, 2009
  16. 16/23 builtin-remote: refactor get_remote_ref_states()Jay Soffian, Feb 24, 2009
  17. 17/23 builtin-remote: new show output styleJay Soffian, Feb 24, 2009
  18. 18/23 builtin-remote: new show output style for push refspecsJay Soffian, Feb 24, 2009
  19. 19/23 test scripts: refactor start_httpd helperJay Soffian, Feb 24, 2009
  20. 20/23 add basic http clone/fetch testsJay Soffian, Feb 24, 2009
  21. 21/23 refactor find_refs_by_name to accept const listJay Soffian, Feb 24, 2009
  22. 22/23 remote: refactor guess_remote_headJay Soffian, Feb 24, 2009
  23. 23/23 remote: use exact HEAD lookup if it is availableJay Soffian, Feb 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.