Re: [PATCH 5/5] setup: make ref storage format configurable via config

From: Justin Tobler <jltobler@gmail.com>
Date: Aug 15, 2024, 22:29 UTC
Message-ID: <c7ssb2tvukrbtftm2ifvz4aobp7hlunfkh3x25x4wysisvih62@utweuhfbcvjd>
In-Reply-To: <a0417b7d1a8e96f71399117f3f7333c5a2920dce.1723708417.git.ps@pks.im>

On 24/08/15 10:00AM, Patrick Steinhardt wrote:

> Similar as the preceding commit, introduce a new "init.defaultRefFormat"

s/as/to/

Show 20 quoted lines

> config that allows the user to globally set the ref storage format used
> by newly created repositories.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  Documentation/config/init.txt |  5 ++++
>  setup.c                       | 14 +++++++++++
>  t/t0001-init.sh               | 44 +++++++++++++++++++++++++++++++++++
>  3 files changed, 63 insertions(+)
> 
> diff --git a/Documentation/config/init.txt b/Documentation/config/init.txt
> index d6f8b6e61b..9be97bcac8 100644
> --- a/Documentation/config/init.txt
> +++ b/Documentation/config/init.txt
> @@ -13,3 +13,8 @@ endif::[]
>  	`--object-format=` in linkgit:git-init[1]. Both the command line option
>  	and the `GIT_DEFAULT_HASH` environment variable take precedence over
>  	this config.
> +`init.defaultRefFormat`::
> +	Allows overriding the default object format for new repositories. See

I think you meant to say "default reference format" here. :)

> +	`--ref-format=` in linkgit:git-init[1]. Both the command line option
> +	and the `GIT_DEFAULT_REF_FORMAT` environment variable take precedence
> +	over this config.

[snip]

The remainder of this patch extends from the previous patch to add support for a configurable default reference format set in a Git config. Nicely done and looks good to me.

-Justin