Re: [PATCH 2/4] fsck: check rev-index checksums
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Apr 18, 2023, 14:24 UTC
- Message-ID
- <c787f354-1cd8-1f27-0559-b0603c259d22@github.com>
- In-Reply-To
- <xmqqwn2ai291.fsf@gitster.g>
On 4/17/2023 6:15 PM, Junio C Hamano wrote:
Show 19 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> +corrupt_rev_and_verify () {
>> + (
>> + pos="$1" &&
>> +...
>> + grep "$error" err
>> + )
>> +}
>
> Curious. Would it work equally well to write
>
> corrupt_rev_and_verify () (
> pos="$1" &&
> ...
> grep "$error" err
> )
>
> without an extra level of indentation?I've never seen that replacement (and it only exists in our tree in t4018/bash-arithmetic-function and t4018/bash-subshell-function) but it works and looks nicer.
Thanks, -Stolee