git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6 (v4)] support for path name caching in rev-cache

From
NENick Edelen <sirnot@gmail.com>
Date
Aug 20, 2009, 12:43 UTC
Message-ID
<c77435a80908200543h74fdb07dm7f30cee4fedef8c5@mail.gmail.com>
In-Reply-To
<alpine.LFD.2.00.0908182313100.6044@xanadu.home>
Show 6 quoted lines
> Result with the rev-cache populated returns the same number of
> revisions, but not the same amount of data.
> [...]
> So... Why is the leading path component dropped sometimes?  That
> explains the output size difference.  And the drop is not coherent
> either:

It looks like I didn't realize that tree_entry() returns only the entry name, and not the full path, which seems like a case of not thinking, just being logical. The unit tests didn't catch it b/c it only occurs for root commits, and none of the root commits in the test had directories involved.

> The object order appears to be rather different.  Why so?

The non-commit object order has to be different because they're added in a different way. It's sorta like vanilla rev-list ordering, except objects are /only/ appended that are introduced per current commit, rather than all that haven't been seen yet. It's still a coherent ordering, and despite the different mechanism I've still enforced the tag-tree-blob ordering of the normal rev-list.

I've fixed the name issue and added that scenario to the unit tests. I'll re-upload this last patch in a bit (either minutes if my flight dosn't leave soon or hours if so).

 - Nick
Previous: Nicolas PitreNext: Nick Edelen
Message 5 of 13 in “support for path name caching in rev-cache”
  1. 6/6 support for path name caching in rev-cacheNick Edelen, Aug 17, 2009
  2. Nicolas PitreAug 18, 2009
  3. Nick EdelenAug 18, 2009
  4. Nicolas PitreAug 19, 2009
  5. Nick EdelenAug 20, 2009
  6. Nick EdelenAug 20, 2009
  7. Nicolas PitreAug 21, 2009
  8. Johannes SchindelinAug 18, 2009
  9. Nick EdelenAug 18, 2009
  10. Nick EdelenAug 21, 2009
  11. Nick EdelenSep 7, 2009
  12. Nick EdelenOct 2, 2009
  13. Nick EdelenOct 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.