Re: [GSoC PATCH v2] decorate: fix sign comparison warnings

From: Arnav Bhate <bhatearnav@gmail.com>
Date: Mar 11, 2025, 18:26 UTC
Message-ID: <c7045e4a-51af-4fff-b6e3-36afff005c77@gmail.com>
In-Reply-To: <CAOLa=ZS=+UGf5yQO3nVhLFJ7BgsSSxigKA3CTqEVez2zkQKyoA@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 16 quoted lines

> Arnav Bhate <bhatearnav@gmail.com> writes:
> 
>> There are multiple instances where ints have been initialized with
>> values of unsigned ints, and where negative values don't mean anything.
>> When such ints are compared with unsigned ints, it causes sign comparison
>> warnings.
>>
>> Also, some of these are used just as stand-ins for their initial
>> values, never being modified, thus obscuring the specific conditions
>> under which certain operations happen.
>>
>> Replace int with unsigned int for 2 variables, and replace the
>> intermediate variables with their initial values for 2 other variables.
> 
> Nit: worthwhile to mention that we also remove the
> `DISABLE_SIGN_COMPARE_WARNINGS` macro as a result of this change.

I'll keep this in mind for my next contribution.

-- 
Regards,
Arnav Bhate
(He/Him)