git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] rebase: fix saving of --signoff state for am-based rebases

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 20, 2019, 18:53 UTC
Message-ID
<c64984e146e509a743c9adc7b61bf7b274103cf9.1576868036.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.680.git.git.1576868036.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>

This was an error introduced in the conversion from shell in commit 21853626eac5 ("built-in rebase: call `git am` directly", 2019-01-18), which was noticed by a random browsing of the code.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 builtin/rebase.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index ddf33bc9d4..e354ec84bb 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -706,7 +706,7 @@ static int rebase_write_basic_state(struct rebase_options *opts)
 		write_file(state_dir_path("gpg_sign_opt", opts), "%s",
 			   opts->gpg_sign_opt);
 	if (opts->signoff)
-		write_file(state_dir_path("strategy", opts), "--signoff");
+		write_file(state_dir_path("signoff", opts), "--signoff");
 
 	return 0;
 }
-- 
gitgitgadget
Previous: Elijah NewrenNext: Junio C Hamano
Message 8 of 10 in “Rebase am fixes”
  1. 0/2 Rebase am fixesElijah Newren via GitGitGadget, Dec 20, 2019
  2. 1/2 am: pay attention to user-defined context sizeElijah Newren via GitGitGadget, Dec 20, 2019
  3. Junio C HamanoDec 20, 2019
  4. Elijah NewrenDec 20, 2019
  5. Elijah NewrenDec 20, 2019
  6. Junio C HamanoDec 20, 2019
  7. Elijah NewrenDec 21, 2019
  8. 2/2 rebase: fix saving of --signoff state for am-based rebasesElijah Newren via GitGitGadget, Dec 20, 2019
  9. Junio C HamanoDec 20, 2019
  10. Johannes SchindelinJan 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.