[PATCH 01/11] test-chmtime: Fix exit code on Windows
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jun 1, 2013, 09:34 UTC
- Message-ID
- <c5913d1a95ed5a9aaa92eece2484274949acc78e.1370076477.git.j6t@kdbg.org>
- In-Reply-To
- <cover.1370076477.git.j6t@kdbg.org>
MinGW's bash does not recognize an exit code -1 as failure. See also 47e3de0e (MinGW: truncate exit()'s argument to lowest 8 bits) and 2488df84 (builtin run_command: do not exit with -1). Exit code 1 is good enough.
Signed-off-by: Johannes Sixt <j6t@kdbg.org> --- test-chmtime.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/test-chmtime.c b/test-chmtime.c index 94903c4..28b2313 100644 --- a/test-chmtime.c +++ b/test-chmtime.c @@ -84,7 +84,7 @@ int main(int argc, char *argv[]) if (stat(argv[i], &sb) < 0) { fprintf(stderr, "Failed to stat %s: %s\n", argv[i], strerror(errno)); - return -1; + return 1; } #ifdef WIN32 @@ -92,7 +92,7 @@ int main(int argc, char *argv[]) chmod(argv[i], sb.st_mode | S_IWUSR)) { fprintf(stderr, "Could not make user-writable %s: %s", argv[i], strerror(errno)); - return -1; + return 1; } #endif @@ -107,7 +107,7 @@ int main(int argc, char *argv[]) if (utb.modtime != sb.st_mtime && utime(argv[i], &utb) < 0) { fprintf(stderr, "Failed to modify time on %s: %s\n", argv[i], strerror(errno)); - return -1; + return 1; } } @@ -115,5 +115,5 @@ int main(int argc, char *argv[]) usage: fprintf(stderr, "usage: %s %s\n", argv[0], usage_str); - return -1; + return 1; }
-- 1.8.3.rc1.32.g8b61cbb