Re: [PATCH/RFC] Created git-basis and modified git-bundle to accept --stdin.

From: Adam Brewster <adam@adambrewster.com>
Date: Jun 24, 2008, 15:30 UTC
Message-ID: <c376da900806240830p2a48aff0uaf6f22372fead5ef@mail.gmail.com>
In-Reply-To: <m3iqvzl091.fsf@localhost.localdomain>

Show 9 quoted lines

>> Git-basis is a perl script that remembers bases for use by git-bundle.
>> Code from rev-parse was borrowed to allow git-bundle to handle --stdin.
>
> I'd rather you follow git-pack-objects, and use `--revs` for the name
> of this option (or even '--not --revs').  The name `--stdin` might
> imply that you are providing objects names on stdin of git-bundle.
>
> But perhaps I am worrying over nothing.
>

This seems like a fine idea.

Show 9 quoted lines

> [...]
>> Then you can add the objects in the bundle to the basis, so they won't
>> get included in the next pack like this:
>>
>>  $ git-basis --update my-basis < my-bundle
>
> Why not use "$(git ls-remote my-bundle)" somewhere in the invocation
> creating new bundle instead?
>

You could use "git ls-remote my-bundle | git-basis --update my-basis" to do the same thing as the command I gave above.

Show 6 quoted lines

>> I'm sure that my implementation is crap, but I think this is a useful
>> idea.  Anybody agree?  Disagree?
>
> Documentation, please?  Especially that it looks like '--stdin' option
> is a bit tricky...
>

I wanted to test the waters and make sure that someone was at least vaguely interested in this (no need to document code that is never going to leave my machine).

I'll prepare another patch with documentation and changing --stdin to --revs when I get a chance.

Thank you, Adam Brewster