Re: [PATCH v4 1/3] update-unicode.sh: automatically download newer definition files
On 05.12.16 21:31, Junio C Hamano wrote:
Show 19 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> On Sat, Dec 03, 2016 at 10:00:47PM +0100, Beat Bolli wrote:
>>> Checking just for the unicode data files' existence is not sufficient;
>>> we should also download them if a newer version exists on the Unicode
>>> consortium's servers. Option -N of wget does this nicely for us.
>>>
>>> Reviewed-by: Torsten Boegershausen <tboegi@web.de>
>>
>> Minor remark (Not sure if this motivates v5, may be Junio can fix it locally?)
>> s/oe/ö/
>>
>> Beside this: Thanks again (and I learned about the -N option of wget)
>
> Will fix up while queuing (only 1/3 needs it, 2/3 has it right).
>
> Also, I'll do s/update-unicode.sh/update_unicode.sh/ on the title
> and the message to match the reality. At some point we might want
> to fix the reality to match people's expectations, though.
Thanks, Junio. This was a bit sloppy of me.
I really appreciate your regard for the small things!
Cheers, Beat