git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] branch: do not fail a no-op --edit-desc

From
Rubén Justo <rjusto@gmail.com>
Date
Oct 1, 2022, 09:15 UTC
Message-ID
<c354947a-06d6-3852-6afe-bd560dd34d6e@gmail.com>
In-Reply-To
<xmqq7d1lom12.fsf@gitster.g>
Let me add, to my other reply to this..
On 30/9/22 0:26, Junio C Hamano wrote:
>> But.. do we want to implement this this way? Maybe we will have to
>> implement on purpose this feature in some future refactorization?
> 
> Absolutely.  It is simpler and there is not much downside.
Once I realize this is porcelain, I strongly agree with this.

The TOCTOU might be resolved, perhaps outside the scope of this patch, warning the user or not allowing two concurrent editions.

Maybe... :-) even I would dig deeper in the TOCTOU, avoiding the call to git_config_set if no change has been made to the branch description.

Anyway, as it is, it's good, imo. Simple and resolves a confuse error removing it. Nice.

> The official stance is "if it hurts, do not do it then".  The side
> discussion about TOCTOU was to see how much hurt we are making the
> user responsible for, and explaining that it is not that much.
>
Previous: Rubén JustoNext: Junio C Hamano
Message 7 of 13 in “branch: do not fail a no-op --edit-desc”
  1. branch: do not fail a no-op --edit-descJunio C Hamano, Sep 28, 2022
  2. Rubén JustoSep 28, 2022
  3. Junio C HamanoSep 28, 2022
  4. Rubén JustoSep 29, 2022
  5. Junio C HamanoSep 29, 2022
  6. Rubén JustoSep 30, 2022
  7. Rubén JustoOct 1, 2022
  8. branch: do not fail a no-op --edit-descJunio C Hamano, Sep 30, 2022
  9. Ævar Arnfjörð BjarmasonSep 30, 2022
  10. Junio C HamanoSep 30, 2022
  11. Ævar Arnfjörð BjarmasonSep 30, 2022
  12. Junio C HamanoSep 30, 2022
  13. branch: do not fail a no-op --edit-descJunio C Hamano, Sep 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.