Re: [PATCH v2 6/6] fetch: add 'refs/bundle/' to log.excludeDecoration

From: Derrick Stolee <derrickstolee@github.com>
Date: Jul 22, 2022, 13:20 UTC
Message-ID: <c34e7106-4409-27db-80b4-44219f5b1518@github.com>
In-Reply-To: <YtnJd+jxDXW4L10R@google.com>

On 7/21/2022 5:47 PM, Josh Steadmon wrote:

Show 15 quoted lines

> On 2022.06.29 20:40, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <derrickstolee@github.com>
>>
>> When fetching from a bundle URI, the branches of that bundle are stored
>> in a different ref namespace: refs/bundles/. This namespace is intended
>> to assist with later 'git fetch' negotiations with a Git server,
>> allowing the client to advertise which data it already has from a bundle
>> URI.
>>
>> These references can be confusing for a user when they appear as a
>> decoration in 'git log' output. Add "refs/bundles/" to the multi-valued
>> log.excludeDecoration config value. This is similar to the way
>> "refs/prefetch/" is hidden by background prefetch operations in 'git
>> maintenance' as added by 96eaffebb (maintenance: set
>> log.excludeDecoration durin prefetch, 2021-01-19).

Show 10 quoted lines

>> +	git_config_set_multivar_gently("log.excludedecoration",
>> +					"refs/bundle/",
>> +					"refs/bundle/",
>> +					CONFIG_FLAGS_FIXED_VALUE |
>> +					CONFIG_FLAGS_MULTI_REPLACE);
>> +
> 
> I dislike the idea of modifying the user's config as a side effect here.
> Since it's a cosmetic issue, can we drop this patch and figure out
> better default values for log.excludedecoration?

You're right.

log.excludeDecoration was initially created precisely for enabling it within the prefetch maintenance task, but it would be better to change which decoration set is shown by default. I'll pull this patch out of this series and bring out another one that rethinks this entire space.

Thanks, -Stolee