Re: git format-patch -s enhancement

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Aug 16, 2021, 07:56 UTC
Message-ID: <c308b4e5-066e-d0d8-ac14-5769d1a47684@gmail.com>
In-Reply-To: <CAJfuBxxT_7weC8_O=KYScSbDcSeBdb3v5d_gtn-NXzW_fKLrsA@mail.gmail.com>

On 16/08/21 06.07, jim.cromie@gmail.com wrote:

Show 27 quoted lines

> hi all
> 
> git format-patch -s is sub-optimal :
> it appends the SoB,
> which falls after the snips
> ---
> changelog ...
> that the commit message may contain
> 
> 
> So it misfires on any maintainer scripts
> expecting the SoB above the 1st snip.
> 
> The workaround is manual SoBs above any snips.
> 
> I note this in -s doc,
> 
>             Add a Signed-off-by trailer to the commit message, using
> the committer identity of yourself.
>             See the signoff option in git-commit(1) for more information.
> 
> "trailer" is really "document current working behavior"
> (normative docu-speak, so to speak;)
> 
> Ideal behavior is to find 1st in-body  --- snip
> and insert there
>

It seems like you don't tell us what snip means. Can you describe your environment and reproduction steps so that I can reproduce this issue?

And next time you can use `git bugreport`.

-- 
An old man doll... just what I always wanted! - Clara