Re: [PATCH v3 00/35] 20210215154427.32693-1-avarab@gmail.com

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 27, 2021, 07:47 UTC
Message-ID: <c2e90134-35bb-24b2-a334-7c6abdd6dc6f@kdbg.org>
In-Reply-To: <20210224195129.4004-1-avarab@gmail.com>

Am 24.02.21 um 20:50 schrieb Ævar Arnfjörð Bjarmason:

Show 11 quoted lines

> Addresses feedback on v2. Since Junio & Johannes expressed a desire to
> keep the existing test scheme in t4018/* it's still there, but it's
> also possible to add *.sh tests in that directory to use the more
> familiar test framework used elsewhere in the test suite.
> 
> The tests added here make use of it to e.g. supply custom -U<n>
> arguments, set config before the tests etc.
> 
> I also improved that existing test support so you can have N tests in
> one file with (mostly) the existing test syntax. See the "userdiff
> tests: add a test with multiple tests in a LANG file" patch.

I've read through all patches and had a comment here and there. I like a lot that we can now put more than one test into a single file.

However, I do not like the shell script version of tests, because the syntax is so hard to read. Also, it looks to me that they are only needed for a few tests that could just as well be coded as one-off tests outside the framework.

I've now pulled avar/t4018-diff-hunk-header-regex-tests-3 from your github repo and will check again if I missed some cruicial points.

-- Hannes