Re: [PATCH 0/2] [RFC] Switch default merge backend from recursive to ort

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 2, 2021, 18:03 UTC
Message-ID: <c27894f0-b0d2-a1a6-bac3-31e82b0283df@gmail.com>
In-Reply-To: <CABPp-BHNYPzJc=oksWfkUGqsrmK_nhr_24WcaqjZoK_+4wG=tA@mail.gmail.com>

On 8/2/2021 12:27 PM, Elijah Newren wrote:

Show 6 quoted lines

> On Mon, Aug 2, 2021 at 9:05 AM Derrick Stolee <stolee@gmail.com> wrote:
>> I've done my own share of testing on some of our private monorepos to see
>> how ORT compares to the recursive algorithm. My data is not perhaps as
>> rigorous as yours, but I did notice that the ORT algorithm was consistently
>> within the 5-6 second range while the recursive algorithm would vary within
>> the 7-20 second range (and some outliers near 30s).

...

Show 5 quoted lines

> One quick question on your timings here, though: in the past, when you
> compared timings, you compared merge-recursive *without* rename
> detection to merge-ort *with* rename detection.  Are you doing the
> same here (just so others have a better sense of what is being
> compared)?

Yes, I continue to test with merge.renames=0 in the config. That makes the data more impressive.

Thanks, -Stolee