git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] shallow.h: document '{commit,rollback}_shallow_file'

From
Taylor Blau <me@ttaylorr.com>
Date
Apr 30, 2020, 19:48 UTC
Message-ID
<c251cf3ef9fe34e78db30c3170b56a496bc45345.1588275891.git.me@ttaylorr.com>
In-Reply-To
<cover.1588275891.git.me@ttaylorr.com>

When 'commit_shallow_file()' and 'rollback_shallow_file()' were introduced, they did not have a documenting comment, when they could have benefited from one.

Add a brief note about what these functions do, and make a special note that they reset stat-validity checks.

Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
---
 shallow.h | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/shallow.h b/shallow.h
index b50a85ed7e..b3bf200bf9 100644
--- a/shallow.h
+++ b/shallow.h
@@ -10,7 +10,9 @@ void set_alternate_shallow_file(struct repository *r, const char *path, int over
 int register_shallow(struct repository *r, const struct object_id *oid);
 int unregister_shallow(const struct object_id *oid);
 int is_repository_shallow(struct repository *r);
+/* commit $GIT_DIR/shallow and reset stat-validity checks */
 int commit_shallow_file(struct repository *r, struct lock_file *lk);
+/* rollback $GIT_DIR/shallow and reset stat-validity checks */
 void rollback_shallow_file(struct repository *r, struct lock_file *lk);
 
 struct commit_list *get_shallow_commits(struct object_array *heads,
-- 
2.26.0.113.ge9739cdccc
Previous: Taylor BlauNext: Taylor Blau
Message 6 of 8 in “shallow: extract a header file”
  1. 0/4 shallow: extract a header fileTaylor Blau, Apr 30, 2020
  2. 1/4 commit: make 'commit_graft_pos' non-staticTaylor Blau, Apr 30, 2020
  3. Junio C HamanoApr 30, 2020
  4. Taylor BlauApr 30, 2020
  5. 2/4 shallow: extract a header file for shallow-related functionsTaylor Blau, Apr 30, 2020
  6. 3/4 shallow.h: document '{commit,rollback}_shallow_file'Taylor Blau, Apr 30, 2020
  7. 4/4 shallow: use struct 'shallow_lock' for additional safetyTaylor Blau, Apr 30, 2020
  8. Taylor BlauApr 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.