git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] asciidoctor-extensions.rb.in: inject GIT_DATE

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Dec 20, 2024, 23:18 UTC
Message-ID
<c17a7319f06e6602337f9e749b32343bbe107dd3.1734734612.git.martin.agren@gmail.com>
In-Reply-To
<cover.1734734612.git.martin.agren@gmail.com>

After a38edab7c8 (Makefile: generate doc versions via GIT-VERSION-GEN, 2024-12-06), we no longer inject GIT_DATE when building with Asciidoctor.

Replace the <date/> tag in the XML to inject the value of GIT_DATE. Unlike <refmiscinfo/> as handled in a recent commit, we have no reason to expect that this tag might be missing, so there's no need for "maybe remove, then add" and we can just outright replace the one that Asciidoctor has generated based on the mtime of the source file.

Compared to pre-a38edab7c8, we now end up injecting this also in the build of Git.3pm, which until now has been using the mtime of Git.pm. That is arguably even a good change since it results in more reproducible builds.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
---
 Documentation/asciidoctor-extensions.rb.in | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/asciidoctor-extensions.rb.in b/Documentation/asciidoctor-extensions.rb.in
index fd1b84c2be..2494f17a51 100644
--- a/Documentation/asciidoctor-extensions.rb.in
+++ b/Documentation/asciidoctor-extensions.rb.in
@@ -31,6 +31,7 @@ module Git
         if document.basebackend? 'docbook'
           output = output.sub(/<refmiscinfo class="source">.*?<\/refmiscinfo>/, "")
           output = output.sub(/<refmiscinfo class="manual">.*?<\/refmiscinfo>/, "")
+          output = output.sub(/<date>.*?<\/date>/, "<date>@GIT_DATE@</date>")
           new_tags = "" \
             "<refmiscinfo class=\"source\">Git @GIT_VERSION@</refmiscinfo>\n" \
             "<refmiscinfo class=\"manual\">Git Manual</refmiscinfo>\n"
-- 
2.48.0.rc0.241.g3cddc25e2a
Previous: Martin ÅgrenNext: Junio C Hamano
Message 5 of 8 in “Asciidoctor fixes for 2.48.0”
  1. 0/3 Asciidoctor fixes for 2.48.0Martin Ågren, Dec 20, 2024
  2. 1/3 asciidoctor-extensions.rb.in: delete existing <refmiscinfo/>Martin Ågren, Dec 20, 2024
  3. Patrick SteinhardtDec 21, 2024
  4. 2/3 asciidoctor-extensions.rb.in: add missing wordMartin Ågren, Dec 20, 2024
  5. 3/3 asciidoctor-extensions.rb.in: inject GIT_DATEMartin Ågren, Dec 20, 2024
  6. Junio C HamanoDec 21, 2024
  7. Patrick SteinhardtDec 21, 2024
  8. Junio C HamanoDec 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.