git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] configure: move definitions of private m4 macros before AC_INIT invocation

From
Stefano Lattarini <stefano.lattarini@gmail.com>
Date
Mar 26, 2012, 16:42 UTC
Message-ID
<c11452d709e597f2f73ac7d5e1eb154f4f2420f3.1332779755.git.stefano.lattarini@gmail.com>
In-Reply-To
<cover.1331333479.git.stefano.lattarini@gmail.com>

This way, no spurious comments nor whitespace will be propagated in the generated configure script.

This change is a pure code movement (plus addition of a comment line).
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
---
 configure.ac |   25 +++++++++++++------------
 1 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 72f7958..0743a70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,18 +1,6 @@
 #                                               -*- Autoconf -*-
 # Process this file with autoconf to produce a configure script.
 
-AC_PREREQ(2.59)
-AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])
-
-AC_CONFIG_SRCDIR([git.c])
-
-config_file=config.mak.autogen
-config_append=config.mak.append
-config_in=config.mak.in
-
-echo "# ${config_append}.  Generated by configure." > "${config_append}"
-
-
 ## Definitions of macros
 # GIT_CONF_APPEND_LINE(LINE)
 # --------------------------
@@ -137,6 +125,19 @@ if test -n "$1"; then
 fi
 ])
 
+## Configure body starts here.
+
+AC_PREREQ(2.59)
+AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])
+
+AC_CONFIG_SRCDIR([git.c])
+
+config_file=config.mak.autogen
+config_append=config.mak.append
+config_in=config.mak.in
+
+echo "# ${config_append}.  Generated by configure." > "${config_append}"
+
 # Directories holding "saner" versions of common or POSIX binaries.
 AC_ARG_WITH([sane-tool-path],
   [AS_HELP_STRING(
-- 
1.7.9
Previous: Stefano LattariniNext: Stefano Lattarini
Message 2 of 4 in “configure: consistency and cosmetic improvements”
  1. 0/3 configure: consistency and cosmetic improvementsStefano Lattarini, Mar 26, 2012
  2. 1/3 configure: move definitions of private m4 macros before AC_INIT invocationStefano Lattarini, Mar 26, 2012
  3. 2/3 configure: avoid some code repetitions thanks to m4_{push,pop}defStefano Lattarini, Mar 26, 2012
  4. 3/3 configure: be more idiomaticStefano Lattarini, Mar 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.