Re: [PATCH 0/3] clean: add `config.exclude` and `--remove-excluded`

From: Ivan Shapovalov <intelfx@intelfx.name>
Date: Feb 11, 2025, 21:42 UTC
Message-ID: <c0e31c9b8da723f4a7bbcc6099ce7e3c00a92fb4.camel@intelfx.name>
In-Reply-To: <xmqq7c5wxjin.fsf@gitster.g>

On 2025-02-11 at 13:24 -0800, Junio C Hamano wrote:

Show 15 quoted lines

> Ivan Shapovalov <intelfx@intelfx.name> writes:
> 
> > On 2025-02-11 at 10:37 -0800, Junio C Hamano wrote:
> > > Ivan Shapovalov <intelfx@intelfx.name> writes:
> > > 
> > > > This series extends the concept of "excluded files" in `git clean` to
> > > > make it useful to protect "precious files" that might be present in a
> > > > specific developer's working tree (see below).
> > > 
> > > How does it interact with "git status"?
> > 
> > In the same way as `git clean -e`, i.e., there is no interaction.
> 
> That is dissapointing.  I was hoping that "git status -u" would list
> precious and ignored ones in two separate sections.

Do I need to implement those interactions in order for this patch set to be considered viable?

Show 7 quoted lines

> 
> > There were no implications behind my usage of the word "precious".
> 
> Then you should ;-)  We'd like to see us use the same language to
> refer to the same concept within this same project (and more
> importantly, avoid misleading people by calling two different things
> with the same phrase).

I did not intend to mislead anyone (as evident by the fact that I was simply not aware of any preexisting connotations). I'd appreciate suggestions for a replacement term.

-- 
Ivan Shapovalov / intelfx /

> 
> > This email was part of the `perl contrib/contacts/git-contacts` output
> > for this patchset, as documented in Documentation/SubmittingPatches
> > and Documentation/MyFirstContribution.txt. Should I have not done that?
> 
> No, as I said, I was curious if he is getting involved with the
> project back again behind the curtain.