Re: [PATCH v2] Makefile: error out invoking strip target

From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Nov 26, 2021, 07:38 UTC
Message-ID: <c057b7fc-54b3-4946-16ad-8fbd548b505d@gmail.com>
In-Reply-To: <xmqqilwf8je9.fsf@gitster.g>

On 26/11/21 14.29, Junio C Hamano wrote:

Show 15 quoted lines

> Bagas Sanjaya <bagasdotme@gmail.com> writes:
> 
>> Now that $INSTALL_STRIP variable can be defined since 3231f41009 (make:
>> add INSTALL_STRIP option variable, 2021-09-05), it is redundant to have
>> 'strip' target when $INSTALL_STRIP does the job. Error out when invoking
>> the target so that users are forced to define the variable instead.
> 
> It is not exactly redundant for folks who like to build and use in
> place without installing.
> 
> What is the reason why we might want to eventually remove the
> "strip" target, making "make strip" an error?  I do not quite see
> much downsides for having just a target with a simple one-liner
> recipe.
>

I think we have two ways to do the same thing (installing stripped) and I want to push users to go with $INSTALL_STRIP instead of strip target.

Regarding deprecation, making $(warning) message instead of $(error) is better option, because users can still use the target (albeit it is deprecated) and they can update their build recipe to use $INSTALL_STRIP before we flip to $(error) or remove the target.

-- 
An old man doll... just what I always wanted! - Clara