Re: [PATCH] Add option to git-commit to allow empty log messages
- From
Miles Bader <miles@gnu.org>
- Date
- Apr 5, 2010, 05:10 UTC
- Message-ID
- <buor5mu7acd.fsf@dhlpc061.dev.necel.com>
- In-Reply-To
- <7vy6h2wsvg.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
> As a Porcelain, "git commit" has some leeway to enforce sensible policy on > the users, and "forbid commit that does not explain anything" is one such > policy. It is not generally a good idea to expose the full capabilities > of plumbing to Porcelain if it leads to bad user behaviour, and such > "artificial" limitations are safety features we do not want to remove.
Isn't the requirement of using a longish option like "--allow-empty-message" enough of a warning to users though?
Although it seems reasonable for git _discourage_ bad practices, I think that should generally also be moderated with "... but if you _reallllly_ want to, you can do this somewhat annoying thing....". Forcing someone to use commit-tree, though, seems a bit much to me; an annoyingly long option seems about right.
-Miles
-- Love is the difficult realization that something other than oneself is real. [Iris Murdoch]