Re: [bug?] checkout -m doesn't work without a base version
- From
Miles Bader <miles@gnu.org>
- Date
- Dec 15, 2011, 04:20 UTC
- Message-ID
- <buoipli8nzy.fsf@dhlpc061.dev.necel.com>
- In-Reply-To
- <7vhb13qbs6.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
>> builtin/checkout.c: In function ‘cmd_checkout’: >> builtin/checkout.c:210:5: warning: ‘mode’ may be used uninitialized >> in this function [-Wuninitialized] >> builtin/checkout.c:160:11: note: ‘mode’ was declared here > > Isn't this just your gcc being overly cautious (aka "silly")? > > The variable "mode" is assigned to when we see an stage #2 entry in the > loop, and we should have updated threeway[1] immediately before doing so. > If threeway[1] is not updated, we would have already returned before using > the variable in make_cache_entry().
Maybe that is actually guaranteed (I dunno), but it's certainly not obvious from the code here, even to a human... any guarantee would have to come from external invariants that the compiler doesn't know about.
Given that, I think it's a fair warning, certainly not "silly." This aspect of the code doesn't seem easy to understand...
-Miles
-- `To alcohol! The cause of, and solution to, all of life's problems' --Homer J. Simpson