Re: [PATCH] t2400: Fix test failures when using grep 2.5

From: Jacob Abel <jacobabel@nullpo.dev>
Date: Jul 15, 2023, 23:36 UTC
Message-ID: <bi4cirtujekrbbzdyjdimgv7shqumvniwqmsyoryfjd4ar2nan@66kcdfsdah3m>
In-Reply-To: <2e22a23f-576f-7a42-ace8-624a5362d9f4@gmail.com>

On 23/07/15 07:15PM, Jacob Abel wrote:

Show 21 quoted lines

> On 23/07/15 09:59AM, Phillip Wood wrote:
> >
> > [...]
>
> [...]
>
> > 
> > Using grep like this makes it harder to debug test failures as one has
> > to run the test with "-x" in order to try and figure out which grep
> > actually failed. I think here we can replace the sequence of "grep"s
> > with "test_cmp"
> > 
> > 	cat >expect <<-EOF &&
> > 	HEAD points to an invalid (or orphaned) reference
> > 	HEAD path: $headpath
> > 	HEAD contents: $headcontents
> > 	EOF
> > 
> > 	test_cmp expect actual
> 
> I'll make these changes.

Actually now that I'm sitting down to make these changes, I'm a bit hesitant as to whether this would be a cleaner solution than what is currently there. I say this as the contents of `actual` are about 10-12 lines in length and some of those lines would vary between the different tests that use this test function. Those specific details don't need to be tested for as they are validated in prior tests and building a perfectly matching `expected` would further complicate that fairly large test function.

> 
> > [...]