Re: [PATCH] rebase -i: allow a comment after a "break" command

From: Olliver Schinagl <oliver@schinagl.nl>
Date: Jan 12, 2023, 11:26 UTC
Message-ID: <bfa6c4d2-b18c-3484-995f-2e3809a5c7d5@schinagl.nl>
In-Reply-To: <pull.1460.git.1673519809510.gitgitgadget@gmail.com>

Hey Phillip,

Thanks for looking into this! Much appreciated!

Show 8 quoted lines

> @@ -869,7 +869,9 @@ the files and/or the commit message, amend the 
> commit, and continue   rebasing.
>   
>   To interrupt the rebase (just like an "edit" command would do, but without
> -cherry-picking any commit first), use the "break" command. 
> +cherry-picking any commit first), use the "break" command. A "break" 
> +command may be followed by a comment beginning with `#` followed by a 
> +space.

Any technical reason for this? Traditionally, anything goes after a comment marker, so why be exceptional here?

Thanks,

Olliver

Show 7 quoted lines

>   
>   If you just want to edit the commit message for a commit, replace the
>   command "pick" with the command "reword".
> diff 
> <https://lore.kernel.org/git/pull.1460.git.1673519809510.gitgitgadget@gmail.com/#iZ31sequencer.c> 
> --git a/sequencer.c b/sequencer.c index bcb662e23be..c66f382dfbc 
> 100644 --- a/sequencer.c +++ b/sequencer.c