Re: [PATCH] Prompt for a username when an HTTP request 401s
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Mar 19, 2010, 09:13 UTC
- Message-ID
- <be6fef0d1003190213m48b6c91dx5cbd489cf798dacc@mail.gmail.com>
- In-Reply-To
- <d411cc4a1003182041p67a93bf6i1528a8eaaab5c805@mail.gmail.com>
Hi,
On Fri, Mar 19, 2010 at 11:41 AM, Scott Chacon <schacon@gmail.com> wrote:
Show 7 quoted lines
> When an HTTP request returns a 401, Git will currently fail with a > confusing message saying that it got a 401. This changes > http_request to prompt for the username and password, then return > HTTP_REAUTH so http_get_strbuf can try again. If it gets a 401 even > when a user/pass is supplied, http_request will now return HTTP_NOAUTH > which remote_curl can then use to display a more intelligent error > message that is less confusing.
(added Daniel to the Cc list)
how are you getting 401s? Recently, git set the CURL_AUTH_ANY option, so if the correct credentials are passed, curl should have "hid" the 401 from us.
-- Cheers, Ray Chuan