Re: Suggestion on git-push --porcelain

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Feb 10, 2010, 11:18 UTC
Message-ID: <be6fef0d1002100318v902689xc937cd332ac752b3@mail.gmail.com>
In-Reply-To: <7vmxzhn6fp.fsf@alter.siamese.dyndns.org>

Hi,

On Wed, Feb 10, 2010 at 10:57 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Tay Ray Chuan <rctay89@gmail.com> writes:
>
>>   $ git push --porcelain
>>   PORCELAIN To git://foo.com/git/myrepo.git
>>   PORCELAIN uptodate refs/heads/baz:refs/heads/baz 1234ab ba4321
>>   PORCELAIN nonff refs/heads/bar:refs/heads/bar 2345cd 3456de
>>
>> This is an "positive" approach, in the sense that we don't remove
>> anything from the current output; we just add more printf("PORCELAIN")
>> lines to wherever is appropriate.
>
> Sorry, but I don't see what that would solve.  For example, we used not to
> give the destination to the standard output stream, but that line carries
> a necessary information and Larry's series corrects that.

I sense a chicken-and-egg situation here.

Printing a "To: <destination>" to stdout is a correction as far as the current non-prefixed output scheme is concerned.

If a prefixed scheme (or some other output scheme) is adopted, then where, or whether, the "To: <destination>" is printed, is not relevant to porcelain script writers - they just get ignored.

> In your "prefix with PORCELAIN" scheme, such a change will start adding a
> new line "PORCELAIN To ..." that older implementations may not be prepared
> to see.

The original --porcelain patch only "porcelained" the output for ref updates, such as

  = TAB refs/heads/master:refs/heads/master TAB [up to date]
  - TAB :refs/heads/foobar TAB [deleted]
 ...

In addition, the "To: <destination>" patch --porcelain is fairly recent - I don't think it has left 'pu', has it? Should we worry about breaking compatibility on something not out yet?

-- 
Cheers,
Ray Chuan