Re: [PATCH v6] add --summary option to git-push and git-fetch
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Jan 31, 2010, 12:04 UTC
- Message-ID
- <be6fef0d1001310404n204ffa31g3cf0a6f170507b3e@mail.gmail.com>
- In-Reply-To
- <20100130020548.GA29343@cthulhu>
Hi,
On Sat, Jan 30, 2010 at 10:05 AM, Larry D'Anna <larry@elder-gods.org> wrote:
Show 10 quoted lines
> --summary will cause git-push to output a one-line of each commit pushed. > --summary=n will display at most n commits for each ref pushed. > > $ git push --dry-run --summary origin : > To /home/larry/gitsandbox/a > 80f0e50..5593a38 master -> master > > 5593a38 foo > > 81c03f8 bar > > Fetch works the same way.
I'm sorry for being late to this discussion; I see the time and work you've put in this and all the previous revisions. But I do have an objection to implementing this behaviour using the option --summary, on the grounds of UI-consistency.
I believe git users are already familiar with --summary in git-diff and git-log, and it might confuse them when the output of --summary for git-push and git-fetch looks different.
Also, I wonder what is the motivation behind displaying this information. Perhaps you are including this to produce output for an IDE? If this is included upstream, then I believe this is the first instance of such verbose information being displayed. Even a fast-forward merge (the closest I can think of that matches this) doesn't show this - I still have to do git log rev1^..rev2 to see.the intervening revisions (inclusive).
-- Cheers, Ray Chuan