Re: coding style: #ifdef blocks and real C blocks

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Mar 1, 2009, 09:27 UTC
Message-ID: <be6fef0d0903010127q7b1491d6o8cdb48acdc674603@mail.gmail.com>
In-Reply-To: <7vbpsl8v7r.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, Mar 1, 2009 at 5:10 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> How about doing something like this:
>
>    #ifdef USE_CURL_MULTI
>    #define active_slot_get get_active_multi_slot
>    #else
>    #define active_slot_get get_active_slot
>    #endif
>

Nice.

Show 14 quoted lines

> Similarly, with something like this:
>
>    #ifdef USE_CURL_MULTI
>    slot active_persistent_slot() {
>            return persistent_connection ? get_active_slot() : get_active_multi_slot();
>    }
>    #else
>    slot active_persistent_slot() {
>            return get_active_slot();
>    }
>    #endif
>
> the call site can be #ifdef free, no?
>

Hmm, so I just do "slot = active_persistent_slot()" ?

-- 
Cheers,
Ray Chuan