git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rm: honor sparse checkout patterns

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Nov 16, 2020, 14:30 UTC
Message-ID
<be43763e-6931-3e84-8e5a-0ac839cc0566@jeffhostetler.com>
In-Reply-To
<70ae5b1d-b1d2-1b3f-11cf-8e5ceafe6048@gmail.com>
On 11/13/20 8:47 AM, Derrick Stolee wrote:
Show 21 quoted lines
> On 11/12/2020 6:54 PM, Elijah Newren wrote:
>> Hi,
>>
>> On Thu, Nov 12, 2020 at 1:02 PM Matheus Tavares
>> <matheus.bernardino@usp.br> wrote:
>>>
>>> Make git-rm honor the 'sparse.restrictCmds' setting, by restricting its
>>> operation to the paths that match both the command line pathspecs and
>>> the repository's sparsity patterns. This better matches the expectations
>>> of users with sparse-checkout definitions, while still allowing them
>>> to optionally enable the old behavior with 'sparse.restrictCmds=false'
>>> or the global '--no-restrict-to-sparse-paths' option.
>>
>> (For Stolee:) Did this arise when a user specified a directory to
>> delete, and a (possibly small) part of that directory was in the
>> sparse checkout while other portions of it were outside?
> 
> The user who suggested this used a command like 'git rm */*.csprojx' to
> remove all paths with that file extension, but then realized that they
> were deleting all of those files from the entire repo, not just the
> current sparse-checkout.

Aren't the wildcards expanded by the shell before the command line is given to Git? So the Git command should only receive command line args that actually match existing files, right??

Jeff
Previous: Matheus Tavares BernardinoNext: Elijah Newren
Message 9 of 42 in “rm: honor sparse checkout patterns”
  1. rm: honor sparse checkout patternsMatheus Tavares, Nov 12, 2020
  2. Elijah NewrenNov 12, 2020
  3. Derrick StoleeNov 13, 2020
  4. Matheus Tavares BernardinoNov 15, 2020
  5. Johannes SixtNov 15, 2020
  6. Matheus Tavares BernardinoNov 16, 2020
  7. Johannes SchindelinNov 23, 2020
  8. Matheus Tavares BernardinoNov 24, 2020
  9. Jeff HostetlerNov 16, 2020
  10. Elijah NewrenNov 17, 2020
  11. rm: honor sparse checkout patternsMatheus Tavares, Nov 16, 2020
  12. 0/7 add/rm: honor sparse checkout and warn on sparse pathsMatheus Tavares, Feb 17, 2021
  13. 1/7 add --chmod: don't update index when --dry-run is usedMatheus Tavares, Feb 17, 2021
  14. Junio C HamanoFeb 17, 2021
  15. Matheus TavaresFeb 18, 2021
  16. 2/7 add: include magic part of pathspec on --refresh errorMatheus Tavares, Feb 17, 2021
  17. Junio C HamanoFeb 17, 2021
  18. 3/7 t3705: add tests for `git add` in sparse checkoutsMatheus Tavares, Feb 17, 2021
  19. Junio C HamanoFeb 17, 2021
  20. Eric SunshineFeb 17, 2021
  21. Junio C HamanoFeb 17, 2021
  22. Matheus Tavares BernardinoFeb 18, 2021
  23. Matheus Tavares BernardinoFeb 18, 2021
  24. Matheus TavaresFeb 18, 2021
  25. Junio C HamanoFeb 18, 2021
  26. Junio C HamanoFeb 18, 2021
  27. Elijah NewrenFeb 22, 2021
  28. 4/7 add: make --chmod and --renormalize honor sparse checkoutsMatheus Tavares, Feb 17, 2021
  29. 5/7 pathspec: allow to ignore SKIP_WORKTREE entries on index matchingMatheus Tavares, Feb 17, 2021
  30. 6/7 add: warn when pathspec only matches SKIP_WORKTREE entriesMatheus Tavares, Feb 17, 2021
  31. Junio C HamanoFeb 19, 2021
  32. Matheus Tavares BernardinoFeb 19, 2021
  33. 7/7 rm: honor sparse checkout patternsMatheus Tavares, Feb 17, 2021
  34. Elijah NewrenFeb 22, 2021
  35. Junio C HamanoNov 16, 2020
  36. Elijah NewrenNov 17, 2020
  37. Elijah NewrenNov 20, 2020
  38. sparse-checkout questions and proposals [Was: Re: [PATCH] rm: honor sparse checkout patterns]Elijah Newren, Dec 31, 2020
  39. Derrick StoleeJan 4, 2021
  40. Elijah NewrenJan 6, 2021
  41. Derrick StoleeJan 7, 2021
  42. Elijah NewrenJan 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.