git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] completion: add remaining flags to checkout

From
Johannes Sixt <j6t@kdbg.org>
Date
Oct 24, 2017, 16:45 UTC
Message-ID
<be2e0547-5ef7-c9d9-baad-44f5fa9d3c31@kdbg.org>
In-Reply-To
<20171024131931.18221-1-thomas.braun@virtuell-zuhause.de>
Am 24.10.2017 um 15:19 schrieb Thomas Braun:
Show 33 quoted lines
> In the commits 1fc458d9 (builtin/checkout: add --recurse-submodules
> switch, 2017-03-14), 08d595dc (checkout: add --ignore-skip-worktree-bits
> in sparse checkout mode, 2013-04-13) and 32669671 (checkout: introduce
> --detach synonym for "git checkout foo^{commit}", 2011-02-08) checkout
> gained new flags but the completion was not updated, although these flags
> are useful completions. Add them.
> 
> The flags --force and --ignore-other-worktrees are not added as they are
> potentially dangerous.
> 
> The flags --progress and --no-progress are only useful for scripting and are
> therefore also not included.
> 
> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
> ---
>   contrib/completion/git-completion.bash | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d934417475..eb6ade6974 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1250,7 +1250,8 @@ _git_checkout ()
>   	--*)
>   		__gitcomp "
>   			--quiet --ours --theirs --track --no-track --merge
> -			--conflict= --orphan --patch
> +			--conflict= --orphan --patch --detach --ignore-skip-worktree-bits
> +			--recurse-submodules --no-recurse-submodules
>   			"
>   		;;
>   	*)
> 

Looks good to me. Thanks, -- Hannes

Previous: Thomas BraunNext: Junio C Hamano
Message 6 of 8 in “completion: add remaining flags to checkout”
  1. 1/1 completion: add remaining flags to checkoutThomas Braun, Oct 12, 2017
  2. Johannes SixtOct 12, 2017
  3. Johannes SixtOct 12, 2017
  4. Thomas BraunOct 24, 2017
  5. 1/1 completion: add remaining flags to checkoutThomas Braun, Oct 24, 2017
  6. Johannes SixtOct 24, 2017
  7. Junio C HamanoOct 25, 2017
  8. Junio C HamanoOct 25, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.