Re: [PATCH] If deriving SVN_SSH from GIT_SSH on msys, also add quotes

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Jan 23, 2010, 20:11 UTC
Message-ID: <bdca99241001231211o97aa0eamacc40bf982a9f022@mail.gmail.com>
In-Reply-To: <7vd410d3as.fsf@alter.siamese.dyndns.org>

On Sat, Jan 23, 2010 at 20:33, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

>> This fixes msysGit issue 385, see
>> http://code.google.com/p/msysgit/issues/detail?id=385
>>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>
> As the patch clearly is inside "msys-only" codepath, I don't mind
> bypassing Eric and apply this directly to my tree before I tag 1.7.0-rc0,
> but may I ask why this quoting magic matters only on msys?

To be honest, I'm not exactly sure why this is required. Maybe the SVN Perl module does some different path mangling than a normal MSYS SVN binary would do. We're already setting SVN_SSH like this (that is, using double-backslashes and quotes) in the msysGit installer, see the discussion at [1]. This patch basically just does the same thing for people that initially chose to not modify the environment during the msysGit installation, but later change GIT_SSH manually, and forget to set SVN_SSH, too.

[1] http://code.google.com/p/msysgit/issues/detail?id=305#c8

-- 
Sebastian Schuberth