git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: check main window visibility before waiting for it to show

From
Beat Bolli <dev+git@drbeat.li>
Date
Jan 10, 2021, 22:23 UTC
Message-ID
<bdaab72b-37f4-658a-716a-d6a958b6f709@drbeat.li>
In-Reply-To
<pull.944.git.git.1610234771966.gitgitgadget@gmail.com>
On 10.01.21 00:26, Tobias Pietzsch via GitGitGadget wrote:
Show 21 quoted lines
> From: Tobias Pietzsch <pietzsch@mycroft.speedport.ip>
>
> If the main window is already visible when gitk waits for it to
> become visible, gitk hangs forever.
> This commit adds a check whether the window is already visible.
> See https://wiki.tcl-lang.org/page/tkwait+visibility
>
> Signed-off-by: Tobias Pietzsch <pietzsch@mycroft.speedport.ip>
> ---
>     gitk: check main window visibility before waiting for it to show
>
>     If the main window is already visible when gitk waits for it to become
>     visible, gitk hangs forever.
>
>     This commit adds a check whether the window is already visible. See
>     https://wiki.tcl-lang.org/page/tkwait+visibility
>
>     The symptom of the for-ever waiting is that gitk shows just an empty
>     window, like this: https://tinyurl.com/yxr5qlf6 It happens (to me) on
>     macOS 11.1 with git-gui installed via homebrew. It doesn't happen on
>     macOS 10.14.

Thanks, this also occurred on my macOS 10.14.6 just an hour ago after a recent brew upgrade, and the patch makes gitk usable again.

Cheers, Beat
Previous: Tobias Pietzsch via GitGitGadgetNext: Johannes Schindelin
Message 2 of 8 in “gitk: check main window visibility before waiting for it to show”
  1. gitk: check main window visibility before waiting for it to showTobias Pietzsch via GitGitGadget, Jan 9, 2021
  2. Beat BolliJan 10, 2021
  3. Johannes SchindelinNov 13, 2024
  4. Paul MackerrasNov 14, 2024
  5. Junio C HamanoNov 14, 2024
  6. Gitk maintainership, was Re: The health of gitkJohannes Sixt, Nov 17, 2024
  7. Paul MackerrasNov 19, 2024
  8. Johannes SixtNov 19, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.