git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What is 'git BRANCH'?

From
SRSverre Rabbelier <alturin@gmail.com>
Date
Jul 29, 2008, 22:49 UTC
Message-ID
<bd6139dc0807291549y66c56fbah928a854f37573680@mail.gmail.com>
In-Reply-To
<7v63qob9hz.fsf@gitster.siamese.dyndns.org>
On Wed, Jul 30, 2008 at 00:39, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> diff --git a/git.c b/git.c
> index 37b1d76..c99e769 100644
> --- a/git.c
> +++ b/git.c
> @@ -448,7 +448,7 @@ int main(int argc, const char **argv)
>                cmd += 4;
>                argv[0] = cmd;
>                handle_internal_command(argc, argv);
> -               die("cannot handle %s internally", cmd);
> +               help_unknown_cmd(cmd);
>        }
>
>        /* Look for flags.. */

Why does handle_internal_command not complain after the " for (i = 0; i < ARRAY_SIZE(commands); i++) {" that no matching commands were found? Is that not an implicit assertion that would do well with being asserted here?

-- 
Cheers,

Sverre Rabbelier
Previous: Junio C HamanoNext: Jeff King
Message 6 of 8 in “What is 'git BRANCH'?”
  1. Jurko GospodnetićJul 29, 2008
  2. Junio C HamanoJul 29, 2008
  3. Kevin BallardJul 29, 2008
  4. Jurko GospodnetićJul 29, 2008
  5. Junio C HamanoJul 29, 2008
  6. Sverre RabbelierJul 29, 2008
  7. Jeff KingJul 30, 2008
  8. Eric RaibleJul 29, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.