git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Development strategy

From
SRSverre Rabbelier <alturin@gmail.com>
Date
Jun 2, 2008, 23:04 UTC
Message-ID
<bd6139dc0806021604w1a066229idb788a9b918ee24b@mail.gmail.com>
In-Reply-To
<484475FC.8020804@gmail.com>
On Tue, Jun 3, 2008 at 12:36 AM, Lea Wiemann <lewiemann@gmail.com> wrote:
> Are you suggesting that the squashed patches get merged, or that the
> squashed patches get reviewed but the finer-granulated patches get merged?

The latter is what I suggested :). I reckon you'll want ot keep the finger-granulated history for future reference / bisecting, but when reviewing that seems overkill.

>  In the former case, I'd probably prefer to work with larger patches in the
> first place (and not just squash them on the review branch), since they are
> easier to handle -- e.g. I sometimes need to go back and change things in
> earlier commits, and in those cases larger commits are easier.

If you don't think you're omitting information you will want later on (meaning the more specific commit history), by all means, go with the bigger patches. I find it nicer to create small commits, with the plus that it cuts down the size of the commit msg too ;).

-- 
Cheers,

Sverre Rabbelier
Previous: Lea WiemannNext: Junio C Hamano
Message 9 of 10 in “Development strategy”
  1. Lea WiemannJun 2, 2008
  2. Sverre RabbelierJun 2, 2008
  3. Jakub NarebskiJun 2, 2008
  4. Sverre RabbelierJun 2, 2008
  5. Johannes SchindelinJun 2, 2008
  6. Stephan BeyerJun 2, 2008
  7. Johannes SchindelinJun 2, 2008
  8. Lea WiemannJun 2, 2008
  9. Sverre RabbelierJun 2, 2008
  10. Junio C HamanoJun 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.