git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] diff: run arguments through precompose_argv

From
Torsten Bögershausen <tboegi@web.de>
Date
May 14, 2016, 05:53 UTC
Message-ID
<bcbb1d5e-1f19-e5a9-2b52-d768d118f412@web.de>
In-Reply-To
<1463172062-4175-2-git-send-email-alex@fournova.com>
On 13.05.16 22:41, Alexander Rinass wrote:
Show 25 quoted lines
> When running diff commands, a pathspec containing decomposed
> unicode code points is not converted to precomposed unicode form
> under Mac OS X, but we normalize the paths in the index and the
> history to precomposed form on that platform.  As a result, the
> pathspec would not match and no diff is shown.
>
> Unlike many builtin commands, the "diff" family of commands do
> not use parse_options(), which is how other builtin commands
> indirectly call precompose_argv() to normalize argv[] into
> precomposed form on Mac OSX.  Teach these commands to call
> precompose_argv() themselves.
>
> Note that precomopose_argv() normalizes not just paths but all
> command line arguments, so things like "git diff -G $string"
> when $string has the decomposed form would first normalized into
> the precomposed form and would stop hitting the same string in
> the decomposed form in the diff output with this change.  It is
> not a problem per-se, as "log" family of commands already use
> parse_options() and call precompose_argv()--we can think of it
> as making the "diff" family of commands behave in a similar way
> as the commands in the "log" family.
>
> Signed-off-by: Alexander Rinass <alex@fournova.com>
> Helped-by: Torsten Bögershausen <tboegi@web.de>
> Helped-by: Junio C Hamano <gitster@pobox.com>
Looks good to me.
Previous: Alexander Rinass
Message 3 of 3 in “diff: run arguments through precompose_argv”
  1. diff: run arguments through precompose_argvAlexander Rinass, May 13, 2016
  2. diff: run arguments through precompose_argvAlexander Rinass, May 13, 2016
  3. Torsten BögershausenMay 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.