git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] t3903: document a pair of directory/file bugs

From
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 8, 2021, 01:43 UTC
Message-ID
<bc66a6ae75d03858f48634612bb60062cc78f5eb.1631065427.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1086.git.git.1631065426.gitgitgadget@gmail.com>
From: Elijah Newren <newren@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t3903-stash.sh | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 873aa56e359..0727a494aa4 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -1307,4 +1307,42 @@ test_expect_success 'stash -c stash.useBuiltin=false warning ' '
 	test_must_be_empty err
 '
 
+test_expect_failure 'git stash succeeds despite directory/file change' '
+	test_create_repo directory_file_switch_v1 &&
+	(
+		cd directory_file_switch_v1 &&
+		test_commit init &&
+
+		test_write_lines this file has some words >filler &&
+		git add filler &&
+		git commit -m filler &&
+
+		git rm filler &&
+		mkdir filler &&
+		echo contents >filler/file &&
+		cp filler/file expect &&
+		git stash push
+	)
+'
+
+test_expect_failure 'git stash can pop directory/file saved changes' '
+	test_create_repo directory_file_switch_v2 &&
+	(
+		cd directory_file_switch_v2 &&
+		test_commit init &&
+
+		test_write_lines this file has some words >filler &&
+		git add filler &&
+		git commit -m filler &&
+
+		git rm filler &&
+		mkdir filler &&
+		echo contents >filler/file &&
+		cp filler/file expect &&
+		git stash push --include-untracked &&
+		git stash apply --index &&
+		test_cmp expect filler/file
+	)
+'
+
 test_done
-- 
gitgitgadget
Previous: Elijah Newren via GitGitGadgetNext: Junio C Hamano
Message 2 of 14 in “Fix D/F issues in stash”
  1. 0/3 Fix D/F issues in stashElijah Newren via GitGitGadget, Sep 8, 2021
  2. 1/3 t3903: document a pair of directory/file bugsElijah Newren via GitGitGadget, Sep 8, 2021
  3. Junio C HamanoSep 8, 2021
  4. 2/3 stash: avoid feeding directories to update-indexElijah Newren via GitGitGadget, Sep 8, 2021
  5. Johannes SchindelinSep 8, 2021
  6. 3/3 stash: restore untracked files AFTER restoring tracked filesElijah Newren via GitGitGadget, Sep 8, 2021
  7. Derrick StoleeSep 8, 2021
  8. Junio C HamanoSep 8, 2021
  9. Johannes SchindelinSep 8, 2021
  10. Derrick StoleeSep 8, 2021
  11. 0/3 Fix D/F issues in stashElijah Newren via GitGitGadget, Sep 10, 2021
  12. 1/3 t3903: document a pair of directory/file bugsElijah Newren via GitGitGadget, Sep 10, 2021
  13. 2/3 stash: avoid feeding directories to update-indexElijah Newren via GitGitGadget, Sep 10, 2021
  14. 3/3 stash: restore untracked files AFTER restoring tracked filesElijah Newren via GitGitGadget, Sep 10, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.