Re: [PATCH v4 0/4] Optionally skip hashing index on write
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Jan 6, 2023, 23:40 UTC
- Message-ID
- <bb48b1e2-819f-8bf3-ef4a-b9e4d23080b2@github.com>
- In-Reply-To
- <xmqqmt6vqo2w.fsf@gitster.g>
On 1/6/2023 5:45 PM, Junio C Hamano wrote:
Show 20 quoted lines
> Derrick Stolee <derrickstolee@github.com> writes: > >> After investigating some of the failures from creating a BUG() statement >> when istate->repo is NULL I see several problems, and they are not related >> to submodules for the most part. >> >> The first issues I've found are due to code paths that operate on the_index >> without actually initializing it with a do_read_index(), or otherwise >> initialize an index using a memset() instead of a common initializer. This >> looks to be a frequent enough problem that solving it would require a >> significant effort. It's not a quick fix. > > Thanks. It is not entirely unexpected X-<, considering how the > connection from the in-core repository and the in-core index has > been developed and evolved. So in short, istate->repo is not yet > ready to be used, until the problems you identified are resolved? > > We probably should start paying down such technical debts. We've > punted on them too many times, saying "yes this is klunky but what > we have is good enough for adding this feature", I suspect?
Yes, I'll make note to prioritize this soon.
Thanks, -Stolee