Re: [PATCH] start_command: reset disposition of all signals in child

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 8, 2023, 15:53 UTC
Message-ID: <ba69ab35-3204-4360-a36d-3253680b2479@gmail.com>
In-Reply-To: <xmqqedj8vfht.fsf@gitster.g>

On 08/09/2023 16:42, Junio C Hamano wrote:

Show 11 quoted lines

> "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> [3] This is really a work-around for not moving the child into its own
>>      process group and changing the foreground process group of the
>>      controlling terminal.
> 
> I am puzzled, as I somehow thought that "does the user conceive a
> subprocess as external and different-from-git entity, or is it
> merely an implementation detail?  many use of subprocesses in our
> codebase, it is the latter." from Peff was a good argument against
> such isolation between spawning "git" and spawned subprocesses.

It is and in those cases we do not ignore SIGINT and SIGQUIT in the parent when we fork the subprocess. What I was trying to say is that in the few cases where we do ignore SIGINT and SIGQUIT in the parent when we fork a subprocess we're working round the child being in the same process group at the parent.

Best Wishes

Phillip