Re: [PATCH] commit-graph: fix a sparse 'integer as NULL pointer' warning

From: Derrick Stolee <stolee@gmail.com>
Date: May 30, 2018, 00:57 UTC
Message-ID: <ba3b8e06-b5e1-99a1-0fe4-ff97d6da8f15@gmail.com>
In-Reply-To: <b22d20c2-f084-1727-cb98-06707e874ef1@ramsayjones.plus.com>

n 5/29/2018 4:01 PM, Ramsay Jones wrote:

Show 10 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/commit-graph-fsck' branch (pu@a84e06bc0f),
> could you please squash this into the relevant patch (commit 80453b4529,
> "commit-graph: add 'verify' subcommand", 2018-05-24).
>
> [No, No, that was the one in graph_read(). :-D ]

Thanks for helping rid me of my bad habits! I'll get this one in v4.

Show 22 quoted lines

>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>   builtin/commit-graph.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
> index 20ce6437a..6abfde5e6 100644
> --- a/builtin/commit-graph.c
> +++ b/builtin/commit-graph.c
> @@ -39,7 +39,7 @@ static struct opts_commit_graph {
>   
>   static int graph_verify(int argc, const char **argv)
>   {
> -	struct commit_graph *graph = 0;
> +	struct commit_graph *graph = NULL;
>   	char *graph_name;
>   
>   	static struct option builtin_commit_graph_verify_options[] = {